Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

acknowledge all contributors to architecture discussions #490

Merged
merged 2 commits into from Jan 27, 2020
Merged

acknowledge all contributors to architecture discussions #490

merged 2 commits into from Jan 27, 2020

Conversation

britram
Copy link
Contributor

@britram britram commented Jan 24, 2020

No description provided.

@britram
Copy link
Contributor Author

britram commented Jan 24, 2020

fixes #419

mwelzl
mwelzl requested changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, I wouldn't mind a mention. I haven't contributed much to this document in particular, I'm sure I did contribute a little too.

@britram
Copy link
Contributor Author

britram commented Jan 27, 2020

oops, i thought you were an author too. added.

@britram britram merged commit c9940f0 into master Jan 27, 2020
@britram britram deleted the acks-419 branch September 11, 2020 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwelzl mwelzl mwelzl requested changes

Assignees
No one assigned
Labels
Architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@britram @mwelzl