Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minset: Fixing wrong statement about missing soft error, name cleanup #952

Merged
merged 1 commit into from Oct 23, 2021
Merged

Minset: Fixing wrong statement about missing soft error, name cleanup #952

merged 1 commit into from Oct 23, 2021

Conversation

mwelzl
Copy link
Contributor

@mwelzl mwelzl commented Oct 21, 2021

As discussed at the last interim, but cleaning up the references to use the real property names too.

@mwelzl mwelzl added the API label Oct 21, 2021
gorryfair
gorryfair approved these changes Oct 21, 2021
View reviewed changes
Copy link
Contributor

@gorryfair gorryfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I'm not hugely sold on "end systems" given my recent experience with the word "system" in arch - but it likely is quite OK here.

@mwelzl
Copy link
Contributor Author

mwelzl commented Oct 21, 2021

Yes, because it's just a quote of the minset RFC's name :) can't change that anymore

@tfpauly tfpauly merged commit 399a654 into master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfpauly tfpauly tfpauly approved these changes

@gorryfair gorryfair gorryfair approved these changes

@abrunstrom abrunstrom Awaiting requested review from abrunstrom

Assignees
No one assigned
Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mwelzl @tfpauly @gorryfair