Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle changes to connection endpoints #962

Merged
merged 2 commits into from Dec 8, 2021
Merged

Handle changes to connection endpoints #962

merged 2 commits into from Dec 8, 2021

Conversation

csperkins
Copy link
Contributor

This makes the following changes:

  • Add AddRemote(), RemoveRemote(), AddLocal(), and RemoveLocal()
    actions to existing connections
  • Update the description of the PathChanged() event to note that it's
    generated if the set of local endpoints available changes
  • Update the peer-to-peer example to show how these can be used to support
    Trickle ICE

Closes #961
Closes #911
Closes #865

This makes the following changes:
* Add `AddRemote()`, `RemoveRemote(), `AddLocal()`, and `RemoveLocal()`
  actions to existing connections
* Update the description of the `PathChanged()` event to note that it's
  generated if the set of local endpoints available changes
* Update the peer-to-peer example to show how these can be used to support
  Trickle ICE

Closes #961
Closes #911
Closes #865
Copy link
Contributor

@mwelzl mwelzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot for doing this!

@tfpauly tfpauly merged commit 57a3d6d into master Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants