Address AD review comments from Ben Kaduk #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All but two comments are addressed in this PR Signed-off-by: Dave Thaler <dthaler@microsoft.com>
|
@kaduk addressing most of your comments in this PR |
mingpeiwk
reviewed
Feb 28, 2022
draft-ietf-teep-architecture.md
Outdated
| @@ -1327,7 +1339,11 @@ from being disclosed to the TAM that distributes them. In such a scenario, | |||
| the files can be encrypted end-to-end between a Trusted Component Signer and a TEE. However, there | |||
| must be some means of provisioning the decryption key into the TEE and/or some | |||
| means of the Trusted Component Signer securely learning a public key of the TEE that it can use to | |||
| encrypt. One way to do this is for the Trusted Component Signer to run its own TAM so that it can | |||
| encrypt. The Trusted Component Signer cannot necessarily even trust the | |||
There was a problem hiding this comment.
Drop a space here: "encrypt. The..."
mingpeiwk
approved these changes
Feb 28, 2022
As Ben stated in his review, some comments are better addressed in a different doc, so these are applied here in the arch doc. Signed-off-by: Dave Thaler <dthaler@microsoft.com>
Signed-off-by: Dave Thaler <dthaler@microsoft.com>
|
Merging per Ming's approval |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All but two AD comments are addressed in this PR
Signed-off-by: Dave Thaler dthaler@microsoft.com