Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.suit Filename #364

Closed
hannestschofenig opened this issue Sep 10, 2023 · 5 comments
Closed

*.suit Filename #364

hannestschofenig opened this issue Sep 10, 2023 · 5 comments
Assignees

Comments

@hannestschofenig
Copy link
Collaborator

The examples in Section 4.4 give the impression that there is a registered filename suffix with .suit. I don't believe there is.

@dthaler
Copy link
Collaborator

dthaler commented Sep 11, 2023

They're just examples, and having an extension might be helpful.

@dthaler
Copy link
Collaborator

dthaler commented Sep 27, 2023

@hannestschofenig what are you proposing here? Remove the .suit suffix?

dthaler added a commit that referenced this issue Oct 7, 2023
Addresses #364

Signed-off-by: Dave Thaler <dthaler@microsoft.com>
@dthaler dthaler self-assigned this Oct 7, 2023
@hannestschofenig
Copy link
Collaborator Author

My proposal is to remove the suffix.

@kentakayama
Copy link
Contributor

kentakayama commented Oct 19, 2023

@hannestschofenig @dthaler @mcd500
My apology for slow reply. Do I need to remove the prefix also in the personalization example?
It also affect to the hash value and signature in suit-authentication-wrapper.

Note

We need to distinguish the Trusted Component and its SUIT Manifest.
They in the example will be stored like:

  • TEEP-Device/
    • SecureFS/
      • 8d82573a926d4754935332dc29997f74/
        • ta
        • suit
      • config.json
      • config.suit

If I remove just .suit it would be

  • TEEP-Device/
    • SecureFS/
      • 8d82573a926d4754935332dc29997f74/
        • ta
        • suit
      • config.json
      • config

If I remove all suit it would be

  • TEEP-Device/
    • SecureFS/
      • 8d82573a926d4754935332dc29997f74/
        • ta
        • ???
      • config.json
      • config

In my opinion, as the SUIT Manifest itself is also a component, some sort of identifier describing it is a SUIT Manifest is valuable.

@dthaler
Copy link
Collaborator

dthaler commented Nov 4, 2023

Fixed in draft -17

@tireddy2 tireddy2 closed this as completed Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants