[Hackathon117] Add encrypted personalization data using ES-ECDH #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kentakayama
changed the title
|
|
I think an example would be very useful! |
kentakayama
force-pushed
the
update-esdh-example
branch
from
3c0b9a3
to
eada985
Compare
|
This example has updated to use KDF context and now ready to merge. |
kentakayama
changed the title
dthaler
requested review from
hannestschofenig,
mcd500,
dthaler and
mingpeiwk
dthaler
reviewed
Sep 27, 2023
hannestschofenig
approved these changes
Oct 6, 2023
|
Looks good for me too. |
mingpeiwk
approved these changes
Oct 6, 2023
|
Can we merge this PR? |
|
In my view this should not be merged until suit-mti changes. |
dthaler
approved these changes
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #330
NOTE: I've generated this binary using t_cose 2 alpha but its status is still fixing some bugs.
Please wait until I can validate this.