Skip to content

Commit

Permalink
Merged from rcross: Add Introduction header to proceedings. Add Ackno…
Browse files Browse the repository at this point in the history
…wlegements to the meeting model. Add a view for acknowlegements. Commit ready for merge.

 - Legacy-Id: 11770
  • Loading branch information
rjsparks committed Aug 9, 2016
2 parents 4631df6 + 4abb502 commit 0b196e5
Show file tree
Hide file tree
Showing 7 changed files with 72 additions and 2 deletions.
32 changes: 32 additions & 0 deletions ietf/meeting/migrations/0033_add_meeting_acknowlegements.py

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions ietf/meeting/models.py
Expand Up @@ -89,6 +89,7 @@ class Meeting(models.Model):
agenda = models.ForeignKey('Schedule',null=True,blank=True, related_name='+')
session_request_lock_message = models.CharField(blank=True,max_length=255) # locked if not empty
proceedings_final = models.BooleanField(default=False, help_text=u"Are the proceedings for this meeting complete?")
acknowledgements = models.TextField(blank=True, help_text="Acknowledgements for use in meeting proceedings. Use ReStructuredText markup.")

def __unicode__(self):
if self.type_id == "ietf":
Expand Down
7 changes: 7 additions & 0 deletions ietf/meeting/tests_views.py
Expand Up @@ -263,6 +263,13 @@ def test_proceedings(self):
r = self.client.get(url)
self.assertEqual(r.status_code, 200)

def test_proceedings_acknowledgements(self):
meeting = make_meeting_test_data()
url = urlreverse('ietf.meeting.views.proceedings_acknowledgements',kwargs={'num':meeting.number})
login_testing_unauthorized(self,"secretary",url)
r = self.client.get(url)
self.assertEqual(r.status_code, 200)

def test_feed(self):
meeting = make_meeting_test_data()
session = Session.objects.filter(meeting=meeting, group__acronym="mars").first()
Expand Down
1 change: 1 addition & 0 deletions ietf/meeting/urls.py
Expand Up @@ -69,6 +69,7 @@
url(r'^materials(?:.html)?/?$', views.materials),
url(r'^proceedings(?:.html)?/?$', views.proceedings),
url(r'^proceedings(?:.html)?/finalize/?$', views.finalize_proceedings),
url(r'^proceedings/acknowledgements/$', views.proceedings_acknowledgements),
]

urlpatterns = [
Expand Down
8 changes: 7 additions & 1 deletion ietf/meeting/views.py
Expand Up @@ -1555,7 +1555,6 @@ def proceedings(request, num=None):
'cache_version': cache_version,
})


@role_required('Secretariat')
def finalize_proceedings(request, num=None):

Expand All @@ -1570,3 +1569,10 @@ def finalize_proceedings(request, num=None):

return render(request, "meeting/finalize.html", {'meeting':meeting,})

@role_required('Secretariat')
def proceedings_acknowledgements(request, num=None):

meeting = get_meeting(num)
return render(request, "meeting/proceedings_acknowledgements.html", {
'meeting': meeting,
})
11 changes: 10 additions & 1 deletion ietf/templates/meeting/proceedings.html
Expand Up @@ -34,7 +34,15 @@ <h1>IETF {{ meeting.number }} {% if not meeting.proceedings_final %}Draft{% endi

{# cache for 15 minutes, as long as there's no proceedings activity. takes 4-8 seconds to generate. #}
{% load cache %}
{% cache 900 ietf_meeting_materials meeting.number cache_version %}
{% cache 900 ietf_meeting_proceedings meeting.number cache_version %}

<h2 class="anchor-target" id="introduction">Introduction</h2>
<div>
<a href="{% url 'ietf.meeting.views.proceedings_acknowledgements' num=meeting.number %}">Acknowledgements</a><br>
<a href="#">IETF Overview</a><br>
<a href="#">Progress Report</a><br>
<a href="#">Attendees</a><br>
</div>

{% with "True" as show_agenda %}
<!-- Plenaries -->
Expand Down Expand Up @@ -163,6 +171,7 @@ <h2 class="anchor-target" id="irtf">IRTF <small>Internet Research Task Force</sm

<div class="col-md-2 hidden-print bs-docs-sidebar" id="affix">
<ul class="nav nav-pills nav-stacked small" data-spy="affix">
<li><a href="#introduction">Introduction</a></li>
{% if plenaries %}
<li><a href="#plenaries">Plenaries</a></li>
{% endif %}
Expand Down
14 changes: 14 additions & 0 deletions ietf/templates/meeting/proceedings_acknowledgements.html
@@ -0,0 +1,14 @@
{% extends "base.html" %}
{# Copyright The IETF Trust 2015, All Rights Reserved #}
{% load origin markup_tags %}

{% block title %}IETF {{ meeting.number }} Proceedings {% endblock %}

{% block content %}
{% origin %}
<h1><a href="{% url 'ietf.meeting.views.proceedings' num=meeting.number %}">IETF {{ meeting.number }} Proceedings</a></h1>
<h2>Acknowledgements</h2>

{{ meeting.acknowledgements | apply_markup:"restructuredtext" }}

{% endblock %}

0 comments on commit 0b196e5

Please sign in to comment.