Skip to content

Commit

Permalink
Changed links to previous reviews go to the doc page of the last
Browse files Browse the repository at this point in the history
result, not the review request page. The doc page will contain the
actual review, so it has all information that is needed. Fixes #2090.
Commit ready for merge.
 - Legacy-Id: 13955
  • Loading branch information
kivinen committed Jul 21, 2017
1 parent 249c345 commit 7154166
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ietf/templates/group/manage_review_requests.html
Expand Up @@ -72,7 +72,7 @@ <h3 class="panel-title">
{% if rlatest.reviewed_rev %}
Previous review of <a href="{% url "ietf.doc.views_doc.document_main" name=rlatest.doc_id rev=rlatest.reviewed_rev %}?include_text=1">{% if rlatest.doc_id != r.doc_id %}{{ rlatest.doc_id }}{% endif %}-{{ rlatest.reviewed_rev }}</a>
(<a href="{{ rfcdiff_base_url }}?url1={{ rlatest.doc.name }}-{{ rlatest.reviewed_rev }}&url2={{ r.doc.name }}-{{ r.doc.rev }}">diff</a>):
<a href="{% url "ietf.doc.views_review.review_request" name=rlatest.doc_id request_id=rlatest.pk %}">{% if rlatest.result %}{{ rlatest.result.name }}{% else %}result unavail.{% endif %}</a>
<a href="{{ rlatest.review.get_absolute_url }}">{% if rlatest.result %}{{ rlatest.result.name }}{% else %}result unavail.{% endif %}</a>
by {{ rlatest.reviewer.person }}{% if rlatest.closed_review_request_event %} {{ rlatest.closed_review_request_event.time.date|date }}{% endif %}
{% else %}
Previous review of <a href="{% url "ietf.doc.views_doc.document_main" name=rlatest.doc_id %}?include_text=1">{% if rlatest.doc_id != r.doc_id %}{{ rlatest.doc_id }}{% else %}this document{% endif %}</a>:
Expand Down

0 comments on commit 7154166

Please sign in to comment.