Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link from milestones back to the charter document page #1044

Closed
ietf-svn-bot opened this issue May 22, 2013 · 7 comments
Closed

Link from milestones back to the charter document page #1044

ietf-svn-bot opened this issue May 22, 2013 · 7 comments

Comments

@ietf-svn-bot
Copy link

owner:olau@iola.dk resolution_fixed type_enhancement | by cmorgan@amsl.com


It would be very helpful for the Secretariat if the charter milestone page (e.g. http://datatracker.ietf.org/wg/jose/milestones/charter/) had a link back to the charter document page (e.g. http://datatracker.ietf.org/doc/charter-ietf-jose/).

Thanks!
Cindy


Issue migrated from trac:1044 at 2022-03-04 02:50:35 +0000

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed owner from martin@iola.dk to olau@iola.dk

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Reassigning to Ole.

Maybe we could add the same top menubar as on the main page (http://datatracker.ietf.org/wg/jose/) --
"Documents | Charter | Manage workflow | Manage delegations | Manage shepherds | History ..." --
ideally by extending a WG page template with the milestone page content.

@ietf-svn-bot
Copy link
Author

@olau@iola.dk changed status from new to closed

@ietf-svn-bot
Copy link
Author

@olau@iola.dk changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@olau@iola.dk commented


Fixed in f75100b:

Add link to charter pages from the milestones editing page (besides
the cancel button), fixes #1044.

@ietf-svn-bot
Copy link
Author

@olau@iola.dk commented


Extending the menu doesn't actually add the link Cindy is asking for and it's getting a bit cluttered (we would potentially have two entries in this case, one for active milestones, one for charter milestones), so I've opted for simple solution in the above commit.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in bb7fbd8:

Merged a603b8e to 0f69f87 from olau@iola.dk:

  • Skip IANA - Review Needed and Version Changed - Review Needed changes from
    IANA as it turns out that the Datatracker is the authoritative source on
    these states. Also improve logging so that the raw JSON from IANA is
    dumped, the parsed JSON on imported changes is dumped and we write to
    syslog before starting a sync script in the notification view.

  • Only add charter state change link when chartering, it doesn't make sense
    for an approved charter. Fixes The doc view of an approved charter has misleading links #861.

  • Don't display group.comments on the charter document page. Apparently
    group.comments have been used by the Secretariat in the past for
    chartering comments, but it's not possible to edit the field and the whole
    thing doesn't make sense from a modelling perspective - a feature like
    this should probably use the note field on the charter. Fixes issue
    Rechartering tool: "Reason for rechartering" can't be changed #1048.

  • Don't crash if an attachment has been created already, just reuse it -
    this case shouldn't actually happen, but apparently sometimes does,
    probably due to a concurrency issue

  • Add link to charter pages from the milestones editing page (besides the
    cancel button), fixes Link from milestones back to the charter document page #1044.

  • Special-case proposed working groups with respect to milestones, they get
    the charter milestones on the WG charter page rather than the current set

  • Show approved milestones on /doc/charter-xyz/ page if the charter is
    approved instead of only showing proposed milestones for proposed charters

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants