Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation is wrongly dated #1046

Closed
ietf-svn-bot opened this issue May 28, 2013 · 9 comments
Closed

Annotation is wrongly dated #1046

ietf-svn-bot opened this issue May 28, 2013 · 9 comments

Comments

@ietf-svn-bot
Copy link

keyword_sprint owner:suresh.krishnan@ericsson.com resolution_fixed type_defect | by magnus.westerlund@ericsson.com


This concerns https://datatracker.ietf.org/doc/draft-ietf-avtcore-srtp-aes-gcm/history/

First uploaded the draft write-up:
2013-05-28 06 Magnus Westerlund Changed document writeup

Then I wrote the annotation update for the draft that is displayed as:

2013-05-20 06 Magnus Westerlund
Still outstanding issues in comment from shepherd.
David McGrew has not replied to IPR question.
Writeup has been uploaded reflecting the -06 version.

However, the associated date and order in the log list is clearly wrong. It really should be 2013-05-28.


Issue migrated from trac:1046 at 2022-03-04 02:50:45 +0000

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


See also #1059

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed priority from n/a to major

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed keywords from `` to sprint

@ietf-svn-bot
Copy link
Author

@suresh.krishnan@ericsson.com changed status from new to assigned

@ietf-svn-bot
Copy link
Author

@suresh.krishnan@ericsson.com changed owner from `` to suresh.krishnan@ericsson.com

@ietf-svn-bot
Copy link
Author

@suresh.krishnan@ericsson.com commented


The code handling the adding of comments was picking up the date from the document instead of using the time at which the comment was added. I have fixed this to pick up the current time while adding to the history.

@ietf-svn-bot
Copy link
Author

@suresh.krishnan@ericsson.com changed status from assigned to closed

@ietf-svn-bot
Copy link
Author

@suresh.krishnan@ericsson.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in ddf45fd:

Merged 60bab5f from suresh.krishnan@ericsson.com:
When working group chairs added an annotation to a document, the date on the
history entry was wrong. It has now been fixed. Fixes issue #1046.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant