Historical meeting agendas should use GroupHistory

[ietf-svn-bot]

owner:olau@iola.dk resolution_fixed type_defect | by olau@iola.dk

---

On 2013-08-09 00:14 Michael Richardson said the following:

While checking the various agenda format outputs against previously saved
output, I learned that the "WG"/"BOF" label of a session is not stable.
When a BOF becomes a WG, the "Group".type changes, and so this affects
historical agenda displays.

Oops. Right. Good point.

I suggest a new field on Session, session_type, which should be a:
session_state = models.ForeignKey(GroupStateName, null=True, blank=True)

with:
def get_session_type(self):
if self.session_state is None:
return self.group.state.name
else:
return self.session_state.name

and then change group_type_str to return that.
It might be that I created group_type_str, but I am thinking I just moved it
from somewhere else.

Yes, it's used in the current template.

However, it seems to me that the correct information is already available by
going back either in the GroupHistory or GroupEvent tables -- no duplicate
information should be needed in the Session table.

Of course, the GroupHistory and GroupEvent tables weren't available when most
of the current agenda display code was written, so it's only now we have the
chance to do this the right way, when removing the shim layer.

Let this be for now; don't add session_state to Session; I'm Cc:ing Ole who
is doing the shim layer removal work that this is a known bug which now can
be done right, given that we save history these days.

---

Issue migrated from trac:1088 at 2022-03-04 02:54:25 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed owner from mcr@sandelman.ca to ``

[ietf-svn-bot]

@rjsparks@nostrum.com changed milestone from `` to Agenda - future

[ietf-svn-bot]

@olau@iola.dk changed owner from `` to olau@iola.dk

[ietf-svn-bot]

@olau@iola.dk changed status from new to closed

[ietf-svn-bot]

@olau@iola.dk changed resolution from `` to fixed

[ietf-svn-bot]

@olau@iola.dk commented

---

Fixed in acda842:

Summary: Make the meeting agenda code use the historic info available
for groups. In the process, added some select_related/prefetch_related
code to cut the number of database queries in the agenda down from
4000-5000 to about 50. Rewritten agenda CSV code to use Python arrays
rather than a template for improved readability/reuse. Rewritten week
view to assemble its data in Python. Plus a few other minor cleanups,
e.g. lame_description is now gone.

Fixes #1088. Branch ready for merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in fb66c18:

Merged in acda842 from olau@iola.dk:
Summary: Make the meeting agenda code use the historic info available
for groups. In the process, added some select_related/prefetch_related
code to cut the number of database queries in the agenda down from
4000-5000 to about 50. Rewritten agenda CSV code to use Python arrays
rather than a template for improved readability/reuse. Rewritten week
view to assemble its data in Python. Plus a few other minor cleanups,
e.g. lame_description is now gone.
Fixes #1088. Branch