Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove use of request.session #1455

Closed
ietf-svn-bot opened this issue Jul 20, 2014 · 5 comments
Closed

Refactor: remove use of request.session #1455

ietf-svn-bot opened this issue Jul 20, 2014 · 5 comments

Comments

@ietf-svn-bot
Copy link

owner:rcross@amsl.com resolution_fixed type_defect | by rcross@amsl.com


Use hidden fields for multipage forms instead of request.session.


Issue migrated from trac:1455 at 2022-03-04 03:48:36 +0000

@ietf-svn-bot
Copy link
Author

@rcross@amsl.com commented


More information:
The secretariat drafts app makes extensive use of this feature to manage multi-page processes for performing actions on a draft. If a user initiates multiple multi-page sequences, in different tabs of the browser, the session data, meant to only handle one sequence at a time, can be corrupted.

Example:

  • Go here: /secr/drafts/[some draft]
  • click New Revision
  • upload a new file and save
  • pause on confirmation page
  • open a new tab
  • repeat process above to confirmation page
  • click cancel
  • return to first tab
  • click save

Django Version: 1.10.7
Exception Type: KeyError
Exception Value:
'action'

@ietf-svn-bot
Copy link
Author

@rcross@amsl.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@rcross@amsl.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@rcross@amsl.com commented


Fixed in 915b445:

Remove all use of request.session from secretariat apps. Add tests for affected views. Fixes #1455. Commit ready for merge.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in 2070bbf:

Merged in 3a2cb9d and 915b445 from rcross@amsl.com:
Remove all use of request.session from secretariat apps. Add tests for affected views. Fixes #1455.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant