Some code doesn't protect itself from the possibility that add_state_change_event can return Null

[ietf-svn-bot]

resolution_fixed type_defect | by rjsparks@nostrum.com

---

AttributeError at /doc/draft-ietf-pcp-server-selection/edit/lastcalltext/

'NoneType' object has no attribute 'desc'

Request Method: 	POST
Request URL: 	https://datatracker.ietf.org/doc/draft-ietf-pcp-server-selection/edit/lastcalltext/
Django Version: 	1.6
Exception Type: 	AttributeError
Exception Value: 	

'NoneType' object has no attribute 'desc'

Exception Location: 	/a/www/ietf-datatracker/web/ietf/doc/views_ballot.py in lastcalltext, line 457
Python Executable: 	/usr/bin/python

Most of the places that the function is currently called is safe - the call is inside an if condition that will ensure the function will return a DocEvent. But in ietf/doc/views_ballot.py there are a couple of places that have no such guarantee, leading to runtime errors as above.

---

Issue migrated from trac:1566 at 2022-03-04 03:58:10 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to closed

[ietf-svn-bot]

@rjsparks@nostrum.com changed resolution from `` to fixed

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in 601575a:

Verify that add_state_change_event returned something before trying to use attributes of the return value. Fixes bug #1566. Commit ready for merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in ff9ae1a:

Merged in 601575a from rjsparks@nostrum.com:
Verify that add_state_change_event returned something before trying to use attributes of the return value. Fixes bug #1566.