The other_director calculation in preparing approval email is incorrect

[ietf-svn-bot]

resolution_fixed type_defect | by rjsparks@nostrum.com

---

As formulated, it would have picked up pre-ads before the change to the way group ads was represented. After that change, it picks up chairs, secretaries, and anyone else with a Role for a group where the ad used to search has an ad role. The expression

    other_director = Person.objects.filter(role__group__role__person=director, role__group__role__name="ad").exclude(pk=director.pk)

is hard to understand anyhow, and should be simplified.

---

Issue migrated from trac:1588 at 2022-03-04 03:59:52 +0000

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

It also needs to better handle the case when a working group document is being handled by an AD from another area for whatever reason.

[ietf-svn-bot]

@rjsparks@nostrum.com changed status from new to closed

[ietf-svn-bot]

@rjsparks@nostrum.com changed resolution from `` to fixed

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Fixed in 786fc38:

Improve the approval mail contents concerning IESG contact members. Fixes #1588. Commit ready for merge.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 99e3f65:

Merged in 786fc38 from rjsparks@nostrum.com:
Improve the approval mail contents concerning IESG contact members. Fixes #1588.