Expired draft "plain text" link returns 404

[ietf-svn-bot]

resolution_fixed type_defect | by rcross@amsl.com

---

Example:
https://www.ietf.org/id/draft-hares-i2rs-auth-trans-04.txt
Source: https://datatracker.ietf.org/doc/draft-hares-i2rs-auth-trans/04/

Presumably this should return www.ietf.org/archive/id/... ?

---

Issue migrated from trac:1876 at 2022-03-04 04:51:48 +0000

[ietf-svn-bot]

@housley@vigilsec.com commented

---

In doc/views_doc.py, there is already code to use the archive URL is the document is not active:

        if doc.get_state_slug() == "active":
            base = settings.IETF_ID_URL
        else:
            base = settings.IETF_ID_ARCHIVE_URL

The problem seems to be that the -04 version of the document is still in the active state.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

The Document is active, and that's what the code is looking at.

Saying "the -04 version is still in the active state" doesn't align with what's modeled - that is, the models don't talk about the state of the -04 version. There are DocHistory objects that might talk about the state at several snapshot points in time when the document happened to be at -04, but that's not what the code is looking at.

I think the bug here is that the if condition you quote needs also to check that the version being looked at is the current version of the document.

[ietf-svn-bot]

@rjsparks@nostrum.com commented

---

Specifically:

    if not snapshot and doc.get_state_slug()=="active":

[ietf-svn-bot]

@housley@vigilsec.com changed status from new to closed

[ietf-svn-bot]

@housley@vigilsec.com changed resolution from `` to fixed

[ietf-svn-bot]

@housley@vigilsec.com commented

---

Fixed in 8ae439a:

If the Internet-Draft is not the current revision, set the URLs to settings.IETF_ID_ARCHIVE_URL. Fixes #1876.

[ietf-svn-bot]

@henrik@levkowetz.com commented

---

Fixed in 051daf6:

Merged in 8ae439a from housley@vigilsec.com:
If the Internet-Draft is not the current revision, set the URLs to settings.IETF_ID_ARCHIVE_URL. Fixes #1876.