Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New non-session form saves single integer as seconds #2208

Closed
ietf-svn-bot opened this issue Feb 23, 2017 · 4 comments
Closed

New non-session form saves single integer as seconds #2208

ietf-svn-bot opened this issue Feb 23, 2017 · 4 comments
Labels
component: secr/ medium

Comments

@ietf-svn-bot
Copy link

owner:rcross@amsl.com resolution_fixed type_defect | by rcross@amsl.com

The form expects a duration in the format HH:MM. If you enter "10" for ten hours, it actually gets saved as 10 seconds. The field needs reasonable validation and should have help text showing the expected format.

Issue migrated from trac:2208 at 2022-03-04 05:45:12 +0000
@ietf-svn-bot
Copy link
Author

@rcross@amsl.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@rcross@amsl.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@rcross@amsl.com commented

Fixed in 4f5933a:

Add placeholders and validations to secretariat non-session time input fields. Fixes #2208. Commit ready for merge.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented

Fixed in 1abb631:

Merged in 4f5933a from rcross@amsl.com:
Add placeholders and validations to secretariat non-session time input fields. Fixes #2208.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: secr/ medium
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ietf-svn-bot