Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review load is being unfairly assigned #2305

Closed
ietf-svn-bot opened this issue May 30, 2017 · 7 comments
Closed

Review load is being unfairly assigned #2305

ietf-svn-bot opened this issue May 30, 2017 · 7 comments

Comments

@ietf-svn-bot
Copy link

resolution_fixed type_defect | by rjsparks@nostrum.com


The code that suggests a reviewer based on position in queue and availability is biasing for only a few reviewers per team, leaving many that are available without assignments.

The current interface makes it difficult for a secretary to see that this is happening.


Issue migrated from trac:2305 at 2022-03-04 05:52:37 +0000

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


From e422717:

Provide assigned dates on review team reviewers page. Fixes #2304. Related to #2305. Commit ready for merge.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


From 2bacdd3:

Merged in e422717 from rjsparks@nostrum.com:
Provide assigned dates on review team reviewers page. Fixes #2304. Related to #2305.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


Fixed in 7f5cef0:

Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes #2305. Commit ready for merge.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


The problem came from an interaction between the page letting you do assignments in batches, and the code that chooses to increment the head of the rotation queue being run assignment by assignment. If the assignments don't happen to be processed in queue order, the place the queue pointer will be at the end is quite likely to be broken.

If the rotation queue looked like D E F G A B C before assignment, and you do three assignments with one Save, and the order the assignments are processed (for whatever reason) assigns F, then E, then D, then the resulting rotation queue looked like this: E F G A B C D

so even though you just assigned stuff to E and F, E will be the next person to get suggested.

I reworked the page that lets you make multiple assignments to be sure they are processed in queue order as much as they can be.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in 108c00a:

Merged in 7f5cef0 from rjsparks@nostrum.com:
Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes #2305.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant