New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review load is being unfairly assigned #2305
Comments
@rjsparks@nostrum.com commented From e422717: Provide assigned dates on review team reviewers page. Fixes #2304. Related to #2305. Commit ready for merge. |
@henrik@levkowetz.com commented From 2bacdd3: Merged in e422717 from rjsparks@nostrum.com: |
@rjsparks@nostrum.com changed status from |
@rjsparks@nostrum.com changed resolution from `` to |
@rjsparks@nostrum.com commented Fixed in 7f5cef0: Reworked how review assigments are processed in order to ensure a team's queue rotates when it should. Fixes #2305. Commit ready for merge. |
@rjsparks@nostrum.com commented The problem came from an interaction between the page letting you do assignments in batches, and the code that chooses to increment the head of the rotation queue being run assignment by assignment. If the assignments don't happen to be processed in queue order, the place the queue pointer will be at the end is quite likely to be broken. If the rotation queue looked like D E F G A B C before assignment, and you do three assignments with one Save, and the order the assignments are processed (for whatever reason) assigns F, then E, then D, then the resulting rotation queue looked like this: E F G A B C D so even though you just assigned stuff to E and F, E will be the next person to get suggested. I reworked the page that lets you make multiple assignments to be sure they are processed in queue order as much as they can be. |
@henrik@levkowetz.com commented Fixed in 108c00a: Merged in 7f5cef0 from rjsparks@nostrum.com: |
resolution_fixed
type_defect
| by rjsparks@nostrum.comThe code that suggests a reviewer based on position in queue and availability is biasing for only a few reviewers per team, leaving many that are available without assignments.
The current interface makes it difficult for a secretary to see that this is happening.
Issue migrated from trac:2305 at 2022-03-04 05:52:37 +0000
The text was updated successfully, but these errors were encountered: