Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft submission tool: YANG validation issue #2398

Closed
ietf-svn-bot opened this issue Oct 31, 2017 · 3 comments
Closed

Draft submission tool: YANG validation issue #2398

ietf-svn-bot opened this issue Oct 31, 2017 · 3 comments

Comments

@ietf-svn-bot
Copy link

resolution_fixed type_defect | by bclaise@cisco.com


Reshad (rrahman@cisco.com) reported this issue with the submission tool, while posting draft-ietf-bfd-yang-07.txt

Benoit, I am in the process of submitting. FYI the submission tool check isn’t finding a module which I am adding in rev07 of the draft.

yanglint 0.13.75: yanglint --verbose -p {rfclib} -p {draftlib} -p {tmplib} {model} -i:
err : Data model "ietf-bfd-types" not found.
err : Importing "ietf-bfd-types" module into "ietf-bfd-mpls" failed.
err : Module "ietf-bfd-mpls" parsing failed.

What I think the issue is (we faced the same on yangvalidator.org):

draft-ietf-bfd-yang-07.txt contains multiple YANG modules.
From http://www.claise.be/IETFYANGPageCompilation.html, we can see:

ietf-bfd@2017-10-30.yang

iana-bfd-types@2017-10-30.yang <======

ietf-bfd-ip-mh@2017-10-30.yang

ietf-bfd-ip-sh@2017-10-30.yang

ietf-bfd-lag@2017-10-30.yang

ietf-bfd-mpls-te@2017-10-30.yang

ietf-bfd-mpls@2017-10-30.yang

Typically iana-bfd-types@2017-10-30.yang would be imported by other YANG modules.
So, while looping through the validation of each of the YANG modules, the other YANG modules should be in the path, ready to be imported.

https://datatracker.ietf.org/doc/draft-ietf-bfd-yang/ doesn't exhibit this issue as this is a cronjob, which extracts all YANG modules before validating them.

Regards, Benoit


Issue migrated from trac:2398 at 2022-03-04 05:59:41 +0000

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in 02ec2aa:

Included the path for draft moduled found invalid in the module paths when running yanglint, in order to avoid some unhelpful model not found messages. Fixes issue #2398.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant