Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML agenda sanitization breaks inline <style> #2470

Closed
ietf-svn-bot opened this issue Mar 14, 2018 · 3 comments
Closed

HTML agenda sanitization breaks inline <style> #2470

ietf-svn-bot opened this issue Mar 14, 2018 · 3 comments

Comments

@ietf-svn-bot
Copy link

keyword_html_santitize_css_style resolution_fixed type_defect | by trammell@tik.ee.ethz.ch


The sanitizer appears, in at least one case (https://datatracker.ietf.org/meeting/101/materials/agenda-101-panrg), to strip the <style> and </style> tags, leaving their content, so CSS directives appear as HTML.

The original of the file in question is at https://github.com/panrg/meeting-materials/blob/master/ietf101-london/agenda.html. It was generated from https://github.com/panrg/meeting-materials/blob/master/ietf101-london/agenda.md by https://github.com/panrg/meeting-materials/blob/master/ietf101-london/mkagenda.sh using the stylesheet at https://github.com/panrg/meeting-materials/blob/master/ietf101-london/agenda.css.


Issue migrated from trac:2470 at 2022-03-04 06:40:54 +0000

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in 428c451:

Added a missing tag to the sanitizer whitelist (telling lxml's Cleaner to not clean style with style=False is apparently not always enough). Fixes issue #2470.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant