Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filling in link should autofetch content of that link #2520

Closed
ietf-svn-bot opened this issue May 31, 2018 · 9 comments
Closed

Filling in link should autofetch content of that link #2520

ietf-svn-bot opened this issue May 31, 2018 · 9 comments

Comments

@ietf-svn-bot
Copy link

resolution_fixed type_defect | by kivinen@iki.fi


When the search function is broken (Like it is now), and I fill in the link manually the system do require me to fill in the content field also. I WILL NOT cut & paste the email there, as that would lead problems, but I can't get forward without filling in the mandatory field, so I had to add one space or similar to there to allow me to save the link.

Either make sure that if I fill in the link the system knows how to fetch the contents of the link and fill it in, or at least make the Review content field not mandatory.


Issue migrated from trac:2520 at 2022-03-04 06:45:33 +0000

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


I suspect you are referring to reviews posted to lists that are not publicly available.

When you say the search function 'is broken' (being more specific would be helpful here) I think the problem is that the list is closed, so the datatracker cannot fetch information for it. If the list was open, then having to cut-and-paste would not be needed, and would not be requested.

How do you propose to autofill the field, when the base of the problem is that the datatracker isn't allowed to see the list posts in the first place?

@ietf-svn-bot
Copy link
Author

@kivinen@iki.fi commented


No, secdir list is not hidden, I am just using the default button in review tool:

Link to review message already sent to secdir@ietf.org

This tries to search email from the list archive, but currently it always fails with error:

Retrieval from mail archive failed: Export failed - this usually means no matches were found (searched for
"draft-ietf-httpbis-h2-websockets", corresponding export). You have to fill in link and content yourself.

If I click the link in the error text (https://mailarchive.ietf.org/arch/search/?q=subject%3A%28draft-ietf-httpbis-h2-websockets%29&email_list=secdir&as=1&qdr=c&start_date=2017-12-02) it will show that there are emails in the archive, but for some reason the automatic system cannot find them. To be able to continue, I need to find the url and type it in the "Link to message" field but then it also requires me to fill in the "Review content".

It seems there is something wrong with the review system when searching for the emails, as it always fails, even when the mailarchive.ietf.org is actually working.

Example of this can be found in:

https://datatracker.ietf.org/doc/draft-ietf-httpbis-h2-websockets/reviewrequest/10525/complete/

if you try to click the "Link to review message already sent to secdir@ietf.org" you get just error.

@ietf-svn-bot
Copy link
Author

@rcross@amsl.com commented


I recently made some changes to the archive export feature that broke this. I will work on a fix.

@ietf-svn-bot
Copy link
Author

@rcross@amsl.com commented


The search feature should be fixed now.

@ietf-svn-bot
Copy link
Author

@kivinen@iki.fi commented


From 0783890:

Removed the requirement for review_content field to be mandatory when
using "link" method. This partially addresses #2520. Commit ready for
merge.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


From b054a14:

Merged in 0783890 from kivinen@iki.fi:
Removed the requirement for review_content field to be mandatory when
using 'link' method. This partially addresses #2520. Commit ready for
merge.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


Tero - what else do you think needs to happen here?

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed resolution from `` to fixed

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant