Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something is still creating Email records with an address that looks like "unknown-email-" #2696

Closed
ietf-svn-bot opened this issue Mar 19, 2019 · 7 comments

Comments

@ietf-svn-bot
Copy link

resolution_fixed type_defect | by rjsparks@nostrum.com


In 95a503ca3039d20f2635ebd514c04bc22f6d49e3: Email.objects.filter(address__icontains="unknown").count()
Out95a503ca3039d20f2635ebd514c04bc22f6d49e3: 97

In 664a6eafac6b75ab0dabef7dd828e469d01e51a2: Counter(Email.objects.filter(address__icontains="unknown").values_list('active',flat=True))
Out664a6eafac6b75ab0dabef7dd828e469d01e51a2: Counter({False: 96, True: 1})

In 1cb5350b07760fd8dbfabc63975836d6eb598dac: Email.objects.filter(address__icontains="unknown",active=True)
Out1cb5350b07760fd8dbfabc63975836d6eb598dac: <QuerySet [<Email: unknown-email-Akihiro-Kato>]>

Issue migrated from trac:2696 at 2022-03-04 07:08:42 +0000

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


From 6a2cf42:

Don't allow users to edit the 'active' value for unknown-email-* addresses. Related to #2696. Commit ready for merge.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


From 9318ae8:

Merged in 6a2cf42 from rjsparks@nostrum.com:
Don't allow users to edit the 'active' value for unknown-email-* addresses. Related to #2696.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


This will be addressed with #2753. Right now the only time unknown-email* are created are when authors don't supply email addresses.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


The code that creates "unknown-email-" email addresses should be unreachable after commit 3939c0b. Will add a log.unreachable() call there and close this ticket.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


From 07375b4:

Added log.unreachable() for the code that creates unknown-email-*' addresses. Addresses issue #2696.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com changed resolution from `` to fixed

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant