Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change in how to find reviewer name in review objects #2717

Closed
ietf-svn-bot opened this issue May 7, 2019 · 7 comments
Closed

change in how to find reviewer name in review objects #2717

ietf-svn-bot opened this issue May 7, 2019 · 7 comments

Comments

@ietf-svn-bot
Copy link

owner:housley@vigilsec.com resolution_fixed type_defect | by kaduk@mit.edu


It looks like the recent work on refactoring review objects made it harder
to find who did a given review. E.g., at
https://datatracker.ietf.org/doc/review-ietf-netconf-restconf-notif-13-secdir-lc-malhotra-2019-
04-11/
there is no "Reviewer name" field, so I either need to look at the
"Completed reviews" section that includes a line for the current review
object or look in the name/title of the oject/page and hope that the
reviewer's surname is in my wetware lookup table.

Not a huge deal, but I figured it might be worth noting.


Issue migrated from trac:2717 at 2022-03-04 07:10:21 +0000

@ietf-svn-bot
Copy link
Author

@housley@vigilsec.com changed owner from `` to housley@vigilsec.com

@ietf-svn-bot
Copy link
Author

@housley@vigilsec.com commented


I have a fix for this. It adds ( <review_team> <review_type> review by ) after the file name.

@ietf-svn-bot
Copy link
Author

@housley@vigilsec.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@housley@vigilsec.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@housley@vigilsec.com commented


Fixed in 8c61965:

Provide information about the refiewer next to the filename. Fixes #2717.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


From 1b5cdfe:

Added review assignment information to the review-document view. Addresses issue #2717.

@ietf-svn-bot
Copy link
Author

ietf-svn-bot commented May 7, 2019

@henrik@levkowetz.com commented


Replying to ietf-svn-conversion/datatracker#2717 (comment:3):

Fixed in 8c61965:

Provide information about the refiewer next to the filename. Fixes #2717.

8c61965 is a reasonable approach, but unfortunately it's based on the pre-6.96.0 models, so will need some tweaks to work with the ReviewAssignment rewrite. See 1b5cdfe.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant