New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reviewer availability emails should include details #2891
Comments
@rjsparks@nostrum.com changed status from |
@mark@painless-security.com commented It turns out that the email template already has an interpolated variable for messages like this, but the calling code fails to supply the variable. If I update the code to supply the variable, then these messages start to appear. This code is included in a function,
Each of these have one or more messages defined. I'm going to change the message passed into the second one (line 1822) to match the formatting you have specified here, and I'll look to improve any formatting on the other invocations as well. If you have a specific request for how these messages should change, please respond on this issue. |
@mark@painless-security.com commented OK, I've implemented the simplest changes to address this issue. The system will now send out four bits of mail. For adding a new (un-)availability period:
For other notifications, I've left the code that generates the message intact, and just forwarded the variable containing the message on to the template. Removal:
User settings change:
End a previously open-ended period:
|
@mark@painless-security.com changed status from |
@mark@painless-security.com changed resolution from `` to |
@mark@painless-security.com commented Fixed in 96bc71f: Add the 'msg' variable for interpolation on reviewer availability change emails, and reformat the add-a-period email. Fixes #2891. Commit ready to merge. |
@henrik@levkowetz.com commented Fixed in 2b68095: Merged in 96bc71f from mark@painless-security.com: |
resolution_fixed
type_enhancement
| by kivinen@iki.fiNow when the reviewer availability changes I as an secretary get email saying:
This is not really that helpful. It would be much better to know whether they marked them unavailable or marked them to available, and what are the dates for next unavailability periods.
I.e., change it to something:
or
or even:
Issue migrated from trac:2891 at 2022-03-04 07:41:56 +0000
The text was updated successfully, but these errors were encountered: