Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when a requested session overlaps an already submitted request #3016

Open
ietf-svn-bot opened this issue Jul 6, 2020 · 18 comments
Open

Comments

@ietf-svn-bot
Copy link

type_defect | by rjsparks@nostrum.com


A recent chair submitted multiple copies of an interim request for the same time.

Two things should be done.

  1. A chair should be warned if his group already has an meeting scheduled or requested at the same time.

  2. Approved requests that are waiting the the announcement queue should be visible to the chair and the secretariat.


Issue migrated from trac:3016 at 2022-03-04 07:54:02 +0000

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed status from new to accepted

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed title from Chairs (and approvers) who have submitted a request can tell when an approved request is sitting in the secretariat's announcement tool to Chairs (and approvers) who have submitted a request can't tell when an approved request is sitting in the secretariat's announcement tool

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


Given the argument in #2929, I think instead of restricting the view of the interim announcement queue (specifically the "announce" tab on /meeting/upcoming) , we show it to everyone.

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com changed status from accepted to assigned

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com changed owner from `` to jennifer@painless-security.com

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com commented


For #2, should login be required or should the view be wide open?

For #1, is there a preferred way to present a warning? Are you imagining a message on the submission form, a confirmation screen or pop-up after an attempt to submit, or something else?

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


The pending and announce queues should be visible by anyone.

I should have said "the attempt to submit the request should fail" when I said warning in the original report. The failure can say why the request didn't go through. I think this can be done with normal form validation.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed owner from jennifer@painless-security.com to ``

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


From b0eeaec:

Allow anyone to see the pending and awaiting announcement tabs on the upcoming meeting view. Fixes #2029. Partially addresses #3016. Commit ready for merge.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in 182aa82:

Merged in b0eeaec from rjsparks@nostrum.com:
Allow anyone to see the pending and awaiting announcement tabs on the upcoming meeting view. Fixes #2929. Partially addresses #3016.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


From ff3f3bd:

Email requesters when an interim moves into the announcement queue. Partially addresses #3016 and #3099. Commit ready for merge.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed status from assigned to waiting

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


What remains is detecting whether a request overlaps an already existing request. Implementing this will require converting the currently naive timestamps into aware ones, which duplicates the general effort to make all of our timestamps aware, so I'm putting what remains here on hold until that general effort completes.

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


From 517ebfa:

Merged in ff3f3bd from rjsparks@nostrum.com:
Email requesters when an interim moves into the announcement queue. Partially addresses #3016 and #3099.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed priority from major to medium

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed title from Chairs (and approvers) who have submitted a request can't tell when an approved request is sitting in the secretariat's announcement tool to Warn when a requested session overlaps an already submitted request

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


Changed summary from:

Chairs (and approvers) who have submitted a request can't tell when an approved request is sitting in the secretariat's announcement tool

to:

Warn when a requested session overlaps an already submitted request

@rjsparks
Copy link
Member

This should have come out of waiting when the tzaware work was deployed.

@rjsparks rjsparks added accepted and removed waiting This is blocked on a dependency or decision not under the maintener's control labels Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants