New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expiration impending: <replaced-draft> #3032
Comments
@rjsparks@nostrum.com changed keywords from `` to |
@rjsparks@nostrum.com changed status from |
@mrcullen42@gmail.com changed status from |
@mrcullen42@gmail.com changed owner from `` to |
@mrcullen42@gmail.com commented Should we also avoid sending Expiration Notices for drafts that have been replaced? Or do you want the Expiration Notice to go out, just not the warning? |
@rjsparks@nostrum.com commented A draft is not active once it is replaced. It moves to the replaced state. It will never move to the expired state. Neither the warnings nor the notice makes sense. |
@mrcullen42@gmail.com commented Okay, that makes sense, and I see that the code to pick expirable drafts only picks ones with a "draft" state of "active". The code changes I am about to submit only warn of expiration in the same case (the "draft" state is "active"), so we only send warnings for drafts we will actually expire. |
@mrcullen42@gmail.com changed status from |
@mrcullen42@gmail.com changed resolution from `` to |
@mrcullen42@gmail.com commented Fixed in dbeb0e8: Fixes #3032: Only send expiration warnings for drafts with a "draft" state of "active", to match the drafts that we will actually expire. Commit ready for merge. |
@rjsparks@nostrum.com commented Fixed in ba29ab8: Merged in dbeb0e8 from mrcullen42@gmail.com: |
keyword_easy
keyword_sprint
owner:mrcullen42@gmail.com
resolution_fixed
type_defect
| by housley@vigilsec.comThe datatracker currently sends warnings about a I-D that is about to expire, even though the datatracker database includes a replaced-by attribute for the I-D. These "expiration impending" should not be sent.
Issue migrated from trac:3032 at 2022-03-04 07:55:39 +0000
The text was updated successfully, but these errors were encountered: