New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AD ballot position links not working #3351
Comments
@rjsparks@nostrum.com changed priority from |
@rjsparks@nostrum.com changed status from |
@jennifer@painless-security.com changed status from |
@jennifer@painless-security.com set owner to |
@jennifer@painless-security.com commented It looks to me like this only happens after opening at least two of the pop-ups without refreshing the browser page. Is that compatible with your "often" experience? |
@lars@eggert.org commented That sounds right. The bug is probably that the modal doesn't get removed from the DOM after it is closed. (This is probably even code I wrote originally, oops.) |
@jennifer@painless-security.com commented Ok. I have a patch that adds the doc name as a prefix, which fixes the problem. I'm planning to leave the modals in the DOM - I think the agenda would become overwhelming to the user before there are enough modals that the HTML bogs down the browser. |
@jennifer@painless-security.com changed status from |
@jennifer@painless-security.com set resolution to |
@jennifer@painless-security.com commented Fixed in 54a524b: Include doc name in ballot popup anchors. Fixes #3351. Commit ready for merge. |
@rjsparks@nostrum.com commented Fixed in 6cdd1c5: Merged in 54a524b from jennifer@painless-security.com: |
owner:jennifer@painless-security.com
resolution_fixed
type_defect
| by lars@eggert.orgThe per-AD ballot position links in the various ballot popups on https://datatracker.ietf.org/iesg/agenda/ are (often) not working, because they are (often) not unique on the page. The anchor needs to be prefixed with the docname, and the link needs to use that.
Issue migrated from trac:3351 at 2022-03-04 09:08:14 +0000
The text was updated successfully, but these errors were encountered: