Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New signing button does a surprising thing if clicked right after logging out #3478

Closed
ietf-svn-bot opened this issue Nov 23, 2021 · 7 comments

Comments

@ietf-svn-bot
Copy link

owner:mark@painless-security.com resolution_fixed type_defect | by rjsparks@nostrum.com


If you click the new signin button right after signing out, you get sent to /accounts/login/?next=/accounts/logout/ which logs you out right after you sign in there.

This will trap a lot of users - it is very confusing. It would be better to look to see if next is logout and suppress it.


Issue migrated from trac:3478 at 2022-03-04 09:21:12 +0000

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed status from new to accepted

@ietf-svn-bot
Copy link
Author

@mark@painless-security.com changed status from accepted to assigned

@ietf-svn-bot
Copy link
Author

@mark@painless-security.com set owner to mark@painless-security.com

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com changed status from assigned to closed

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com set resolution to fixed

@ietf-svn-bot
Copy link
Author

@jennifer@painless-security.com commented


Fixed in c4bf508:

Do not redirect user to the logout page when logging in. Fixes #3478. Commit ready for merge.

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


Fixed in 0205d13:

Merged in c4bf508 from jennifer@painless-security.com:
Do not redirect user to the logout page when logging in. Fixes #3478.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant