Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to review document without corresponding assignment returns server error #3906

Closed
1 task done
jennifer-richards opened this issue Apr 28, 2022 · 1 comment
Closed
1 task done
Labels
bug Something isn't working component: doc/ major

Comments

@jennifer-richards
Copy link
Member

What happened?

Crash reports came in for /doc/review-ietf-v6ops-slaac-renum-03-secdir-lc-wierenga-2020-09-24/. (This is a sandbox link - effectively the same behavior is seen on production)

The error reported on production is as follows (sandbox is the same, except with a debug message instead of an empty name keyword argument)

django.urls.exceptions.NoReverseMatch: Reverse for 'ietf.doc.views_doc.document_main' with keyword arguments '{'name': ''}' not found. 1 pattern(s) tried: ['doc/(?P<name>[A-Za-z0-9._+-]+?)(?:/(?P<rev>[0-9]{1,2}(-[0-9]{2})?))?/$']

Poking, it seems that assignments = ReviewAssignment.objects.filter(review__name=doc.name) on l.708 of views_doc.py is empty, which makes its way to review_req being None.

What browser(s) are you seeing the problem on?

Not Applicable

Code of Conduct

  • I agree to follow the IETF's Code of Conduct
@rjsparks
Copy link
Member

This is definitely a data error. Maybe code can protect itself better, but it is a violation of schema.
There are two review documents in this state at the moment, both quite old.

rjsparks added a commit to rjsparks/datatracker that referenced this issue Apr 29, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working component: doc/ major
Projects
None yet
Development

No branches or pull requests

2 participants