Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning when character limit is exceeded on Cancel Interim Meeting Request page #6998

Closed
1 task done
cindymorgan opened this issue Jan 30, 2024 · 3 comments · Fixed by #7069
Closed
1 task done
Assignees

Comments

@cindymorgan
Copy link
Collaborator

Describe the issue

The comments field on the page to cancel an interim meeting (e.g. https://datatracker.ietf.org/meeting/interim/request/interim-2024-nfsv4-02/cancel) apparently has 255-character limit, and exceeding that makes the form return a 500 internal server error.

It would be helpful if the form could warn that the character limit was being exceeded, or if the error message that is returned was more descriptive than just a generic "internal server error."

Code of Conduct

@cindymorgan cindymorgan added the bug Something isn't working label Jan 30, 2024
@rjsparks
Copy link
Member

form could be told to stop taking input after 255 characters.

But - is 255 enough for what's needed in the field? Do we need to make it larger?

@cindymorgan
Copy link
Collaborator Author

I ran into issues because I was trying to paste in a message from the chairs verbatim, which came in at around ~400 characters. I was able to pare it down, but maybe expanding this to 500 or so would be useful.

@rjsparks
Copy link
Member

rjsparks commented Feb 1, 2024

Right - we should expand the field to 512, make the control aware of the limit, and harden the POST against attempted abuse so this path to a 500 is removed.

pselkirk added a commit to pselkirk/datatracker that referenced this issue Feb 16, 2024
rjsparks pushed a commit that referenced this issue Feb 20, 2024
…h to 512 (#7069)

* fix: Expand and enforce Cancel Interim Meeting Request comments length to 512 (#6998)

* fix: Verify comment text in generated email
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants