Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a manual editing step from the secretariats workflow on sending a 5742 response #812

Closed
ietf-svn-bot opened this issue Mar 15, 2012 · 4 comments

Comments

@ietf-svn-bot
Copy link

keyword_sprint resolution_fixed type_enhancement | by rjsparks@nostrum.com


Currently, when the datatracker generates the email message to send to the ISE or IRTF in response to an RFC5742 review, it includes the sentence:

"The IESG would also like the IRSG or RFC-Editor to review the comments in the datatracker ([ doc_url ]) related to this document and determine whether or not they merit incorporation into the document. Comments may exist in both the ballot and the history log."

The secretariat manually removes whichever of the IRSG or RFC-Editor the message is not going to before sending the message.

This template already knows who the message is going to (it uses that to populate the To header field). It should build that sentence such that the secretariat does not have to edit it.


Issue migrated from trac:812 at 2022-03-04 02:30:23 +0000

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed status from new to closed

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com changed resolution from `` to fixed

@ietf-svn-bot
Copy link
Author

@rjsparks@nostrum.com commented


Fixed in 798e7a5:

  • Adds a new document type for conflict reviews, with a ballot for the IESG 5742 response to a review request
  • Integrated the new document type into the iESG agenda views (including RSS feeds)
  • Removed the Edit and Add buttons from the document main view.
  • Replaced Add with actions appropriate for the document type, such as "Begin IESG Processing" or "Begin IETF Conflict Review", and made most data directly editable on the document's main page, depending on access permissions.
  • Removed a manual editing step that the secretariat had to perform when sending conflict review messages. The view now composes the message correctly given the stream.
  • Added a pencil icon motif to differentiate fields that are editable.
  • Generalized several views and helper functions to use Document instead of (e.g.) IdWrapper
  • Generalized reading documents from the repository
  • Added a way to get from IdWrapper to the underlying Document to facilitate migrating way from the Wrapper classes
  • Added many helpers to Document to assist with migrating off IdWrapper
  • Minor fixes and other changes
    • Fixes to document main view to avoid (silent) template failures.
    • Began removing some of the code that is no longer reachable post-migration
    • Corrected the behavior of the undefer code and added test cases for it
    • Improved initial population of notification lists and added the ability to regenerate the initial list
  • Made the test code that scans for template coverage more robust
  • Deployment notes:
    • new setting: CONFLICT_REVIEW_PATH. The associated directory will need to be created

This branch fixes bugs #805, #744 and #812

@ietf-svn-bot
Copy link
Author

@henrik@levkowetz.com commented


Fixed in 798f769:

Merged 798e7a5 from rjsparks@nostrum.com:

  • Adds a new document type for conflict reviews, with a ballot for the IESG 5742 response to a review request
  • Integrated the new document type into the iESG agenda views (including RSS feeds)* Removed the Edit and Add buttons from the document main view.
  • Replaced Add with actions appropriate for the document type, such as "Begin IESG Processing" or "Begin IETF Conflict Review", and made most data directly editable on the document's main page, depending on access permissions.
  • Removed a manual editing step that the secretariat had to perform when sending conflict review messages. The view now composes the message correctly given the stream.
  • Added a pencil icon motif to differentiate fields that are editable.
  • Generalized several views and helper functions to use Document instead of (e.g.) IdWrapper
  • Generalized reading documents from the repository
  • Added a way to get from IdWrapper to the underlying Document to facilitate migrating way from the Wrapper classes* Added many helpers to Document to assist with migrating off IdWrapper
  • Minor fixes and other changes
    • Fixes to document main view to avoid (silent) template failures.
    • Began removing some of the code that is no longer reachable post-migration * Corrected the behavior of the undefer code and added test cases for it
    • Improved initial population of notification lists and added the ability to regenerate the initial list
  • Made the test code that scans for template coverage more robust
  • Deployment notes:
    • new setting: CONFLICT_REVIEW_PATH. The associated directory will need to be created

This branch fixes bugs #805, #744 and #812

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant