Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prevent ADs and chairs from being added to bethere constraint #5169

Merged
merged 5 commits into from Feb 21, 2023

Conversation

larseggert
Copy link
Collaborator

@larseggert larseggert commented Feb 17, 2023

Fixes #5163 and #3890.

Also fix a js error while I'm here.

ietf/secr/sreq/forms.py Outdated Show resolved Hide resolved
Co-authored-by: Robert Sparks <rjsparks@nostrum.com>
@codecov
Copy link

codecov bot commented Feb 18, 2023

Codecov Report

Merging #5169 (8513163) into main (f9c2376) will decrease coverage by 0.01%.
The diff coverage is 77.77%.

❗ Current head 8513163 differs from pull request most recent head 6bc8ffe. Consider uploading reports for the commit 6bc8ffe to get more accurate results

@@            Coverage Diff             @@
##             main    #5169      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         295      295              
  Lines       40046    40059      +13     
==========================================
+ Hits        35458    35466       +8     
- Misses       4588     4593       +5     
Impacted Files Coverage Δ
ietf/secr/sreq/forms.py 97.32% <77.77%> (-0.99%) ⬇️
ietf/utils/text.py 85.97% <0.00%> (-1.22%) ⬇️
ietf/doc/views_search.py 89.02% <0.00%> (-0.21%) ⬇️
ietf/api/views.py 89.44% <0.00%> (-0.03%) ⬇️
ietf/api/urls.py 100.00% <0.00%> (ø)
ietf/doc/views_doc.py 91.53% <0.00%> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@larseggert larseggert changed the title fix: Prevent ADs and chairs from added to bethere constraint fix: Prevent ADs and chairs from being added to bethere constraint Feb 19, 2023
@rjsparks rjsparks merged commit cb7abbc into ietf-tools:main Feb 21, 2023
@larseggert larseggert deleted the fix-5163 branch February 21, 2023 17:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wording change on /secr/sreq
3 participants