-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add remote instructions and date/time to interim agenda page #6442
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6442 +/- ##
==========================================
- Coverage 88.71% 88.70% -0.01%
==========================================
Files 290 290
Lines 40436 40436
==========================================
- Hits 35871 35868 -3
- Misses 4565 4568 +3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see the above comments on the discussion tab)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for continuing to improve things for meeting participants.
I think we need a few more touches before merging this -
at http://localhost:8000/meeting/interim-2023-cbor-16/session/cbor I see:
It would be good to put the timezone selectors there as well (instead of the current showing of timezone declared for the meeting), again with default to local (?).
At http://localhost:8000/doc/agenda-interim-2023-cbor-16-cbor-01/ I see:
The time happens to be in Local (I think) but the Local cell is not selected so it's not clear what the timezone is until clicking around a bit.
Also, when the Meeting
option is pressed, the result is:
which says nothing about what timezone that actually is?
@rjsparks last commit should fix your issues. I couldn't reproduce "Local cell is not selected", it is selected in my dev instance. (Did you |
Fixes #6433
Fixes #6249