Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add remote instructions and date/time to interim agenda page #6442

Merged
merged 11 commits into from
Oct 12, 2023

Conversation

larseggert
Copy link
Collaborator

Fixes #6433
Fixes #6249

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #6442 (1763d74) into main (16f9e0e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6442      +/-   ##
==========================================
- Coverage   88.71%   88.70%   -0.01%     
==========================================
  Files         290      290              
  Lines       40436    40436              
==========================================
- Hits        35871    35868       -3     
- Misses       4565     4568       +3     

see 2 files with indirect coverage changes

@rjsparks
Copy link
Member

This shows whatever time the people created the meeting, but everywhere else we've moved to showing the time in UTC by default and using JS to show options (utc, local, meeting time). This view should do the same.
image

@rjsparks
Copy link
Member

We should also put the date and time on the group meetings page.
For future and in-progress sessions, the time should show here somewhere:
image

Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see the above comments on the discussion tab)

Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for continuing to improve things for meeting participants.

I think we need a few more touches before merging this -

at http://localhost:8000/meeting/interim-2023-cbor-16/session/cbor I see:

image

It would be good to put the timezone selectors there as well (instead of the current showing of timezone declared for the meeting), again with default to local (?).

At http://localhost:8000/doc/agenda-interim-2023-cbor-16-cbor-01/ I see:
image

The time happens to be in Local (I think) but the Local cell is not selected so it's not clear what the timezone is until clicking around a bit.

Also, when the Meeting option is pressed, the result is:
image
which says nothing about what timezone that actually is?

@larseggert
Copy link
Collaborator Author

larseggert commented Oct 11, 2023

@rjsparks last commit should fix your issues. I couldn't reproduce "Local cell is not selected", it is selected in my dev instance. (Did you yarn legacy:build?)

@rjsparks rjsparks merged commit fa00abf into ietf-tools:main Oct 12, 2023
9 checks passed
@larseggert larseggert deleted the fix-6433 branch October 12, 2023 12:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants