Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve idnits2_state document creation time calculations #6832

Merged
merged 2 commits into from Dec 21, 2023

Conversation

rjsparks
Copy link
Member

@rjsparks rjsparks commented Dec 21, 2023

Fixed #6771

@rjsparks rjsparks requested a review from kesara December 21, 2023 20:27
Copy link
Member

@kesara kesara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Add a test case for the draft that becomes RFC as well?

url = urlreverse('ietf.doc.views_doc.idnits2_state', kwargs=dict(name=rfc.name))

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (f3a574c) 88.78% compared to head (f8fb41a) 88.78%.
Report is 5 commits behind head on main.

Files Patch % Lines
ietf/doc/views_doc.py 36.36% 7 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6832   +/-   ##
=======================================
  Coverage   88.78%   88.78%           
=======================================
  Files         285      285           
  Lines       40324    40372   +48     
=======================================
+ Hits        35800    35843   +43     
- Misses       4524     4529    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit c328ff7 into ietf-tools:main Dec 21, 2023
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2023
@rjsparks rjsparks deleted the idnits2-state branch January 9, 2024 21:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError at /doc/draft-ietf-rreq-iprouters-require/idnits2-state/
2 participants