refactor: Move cron jobs to celery tasks #6926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Equivalent to the fetch_meeting_attendance management command
Ignore results by default, but enable the backend so we can manage tasks
Misunderstood the comment, "fixed" a non-bug. Oops.
rjsparks
reviewed
Jan 22, 2024
| @@ -56,7 +56,7 @@ $DTDIR/ietf/bin/expire-last-calls | |||
| # Run an extended version of the rfc editor update, to catch changes | |||
| # with backdated timestamps | |||
| # Enable when removed from /a/www/ietf-datatracker/scripts/Cron-runner: | |||
| $DTDIR/ietf/bin/rfc-editor-index-updates -d 1969-01-01 | |||
| $DTDIR/ietf/bin/rfc-editor-index-updates -d 1969-01-01 | |||
rjsparks
approved these changes
Jan 22, 2024
|
cronch |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a first batch of celery tasks to replace some of the jobs done by cron. Adds a simple management command to actually schedule the tasks, which is done with them disabled. This should be suitable for a first test deployment where we manually disable the cron task and enable its celery equivalent to see how things go.
The management command
periodic_tasks --create-defaultwill set up the schedules. Running it without any options will summarize the cron-like tasks. It also accepts--enableor--disableto enable or disable a task by its PK, although the admin interface is probably a nicer way to do this.