Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make review settings history usable (fixes #3213). #7205

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

kivinen
Copy link
Contributor

@kivinen kivinen commented Mar 16, 2024

Makes the history of the review settings usable, by filtering out useless "skipped" and "None" entries from the list unless they have some actual changes to the settings (i.e., if the delta change count is not zero). Also do not save settings every single time when document is assigned to anybody for everybody, i.e., only do bulk update for those users whose skip_next count was decremented. Added some more useful change reasons.

This should fix #3213.

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 69.69697% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 88.92%. Comparing base (187c2c5) to head (9239dc3).
Report is 62 commits behind head on main.

Files Patch % Lines
ietf/doc/templatetags/ietf_filters.py 28.57% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7205      +/-   ##
==========================================
- Coverage   88.98%   88.92%   -0.07%     
==========================================
  Files         291      291              
  Lines       40717    41090     +373     
==========================================
+ Hits        36233    36540     +307     
- Misses       4484     4550      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit cec0e0c into ietf-tools:main Mar 21, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

History of reviewer settings does not seem to list everything
3 participants