New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: email ingestion API #7342
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately this does not mix well with the conditional "year" property.
This reverts commit e498022.
# Conflicts: # ietf/api/tests.py # ietf/api/views.py
rjsparks
previously approved these changes
Apr 22, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7342 +/- ##
==========================================
- Coverage 88.98% 88.85% -0.14%
==========================================
Files 291 291
Lines 40717 41028 +311
==========================================
+ Hits 36233 36456 +223
- Misses 4484 4572 +88 ☔ View full report in Codecov by Sentry. |
rjsparks
approved these changes
Apr 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an http API for accepting and ingesting emails. Supports IANA review, IPR response, and nomcom feedback email ingestion. For IPR and nomcom messages, email is sent to admins (or nomcom chair, if possible) to notify them of the failure. This is not done for IANA - it could be, but the old script did not have that feature so I've not added it.
The rather baroque
EmailOnFailureCommand
features are mirrored in a similarly baroqueEmailIngestionError
class and its handling in theingest_email()
view. This is intended to allow for consistent handling of these email forwards. Having gone through the exercise of implementing it and writing tests for it, I'm not thoroughly convinced that it's actually making things better. It has the very desirable feature of being already written, though.The message format for the API calls is defined by a JSON schema - it's
for
ipr-response
andiana-review
dests andfor
nomcom-feedback
dest.