This repository has been archived by the owner on Apr 24, 2020. It is now read-only.
Start AUTH48 processing #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpu
approved these changes
Feb 19, 2019
There was a problem hiding this comment.
Both the markdown diff and the XML diff & responses to the RFC editor look good to me. Thanks for making the edits in this branch @bifurcation
| rfced:: | ||
| kramdown-rfc2629 draft-ietf-acme-acme.md >rfced/draft-ietf-acme-acme.xml | ||
| cd rfced && python clean-xml.py <draft-ietf-acme-acme.xml >draft-ietf-acme-acme.clean.xml | ||
| -cd rfced && diff -u draft-ietf-acme-acme.clean.xml rfc8555.edited.xml >curr.diff |
There was a problem hiding this comment.
No, the leading minus means ignore exit status from the command-line.
There was a problem hiding this comment.
Ahhh! That makes sense. Thanks @richsalz
richsalz
approved these changes
Feb 19, 2019
richsalz
approved these changes
Feb 19, 2019
| rfced:: | ||
| kramdown-rfc2629 draft-ietf-acme-acme.md >rfced/draft-ietf-acme-acme.xml | ||
| cd rfced && python clean-xml.py <draft-ietf-acme-acme.xml >draft-ietf-acme-acme.clean.xml | ||
| -cd rfced && diff -u draft-ietf-acme-acme.clean.xml rfc8555.edited.xml >curr.diff |
There was a problem hiding this comment.
No, the leading minus means ignore exit status from the command-line.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RFC Editor has completed their editing pass on ACME and assigned us RFC number -- ACME will be RFC 8555 馃帀馃帄
In order to finalize the RFC, we now need to reconcile that with the edits that have come in while they were working, and return to them an updated XML document.
This PR takes the first few steps in that process:
rfceddirectory with:clean-xml.pythat removes some artifacts that kramdown-rfc2629 introducesrfc8555.xmldraft-ietf-acme-acme.xml- Raw output from kramdown-xml2rfcdraft-ietf-acme-acme.clean.xml- Output from clean-xml.pyrfc8555.src-clean.xml- Same content as draft.clean.xml, but has RFC editor's technical XML changesrfc8555.edited.xml- Content is the same as rfc.xml, but has:The authors, chairs, and ADs are currently working on a plan to work this through to completion.