Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security Considerations #33

Closed
boucadair opened this issue Mar 20, 2023 · 8 comments · Fixed by #68
Closed

Security Considerations #33

boucadair opened this issue Mar 20, 2023 · 8 comments · Fixed by #68
Labels
WGLC comment received during WGLC

Comments

@boucadair
Copy link
Contributor

I'm afraid that the following text is to be revised:

None of the readable data nodes in these YANG module are considered sensitive or vulnerable in network environments. The NACM "default-deny-all" extension has not been set for any data nodes defined in these module.

None of the writable data nodes in these YANG modules are considered sensitive or vulnerable in network environments. The NACM "default-deny-write" extension has not been set for any data nodes defined in these modules.

There are several sensitive data node that should be listed. Access to some data by non-authorized parties may reveal internal topologies/etc.

There should be also a note about the "http-listen" use.

@boucadair boucadair added the WGLC comment received during WGLC label Mar 20, 2023
fno2010 added a commit that referenced this issue May 9, 2023
No senstive data is aware in the modules defined in this document. But
the extended modules may have. Add a paragraph to clarify this. (#33)

Signed-off-by: jensenzhang <jingxuan.n.zhang@gmail.com>
@fno2010
Copy link
Member

fno2010 commented May 9, 2023 via email

@fno2010
Copy link
Member

fno2010 commented May 9, 2023 via email

@fno2010
Copy link
Member

fno2010 commented May 11, 2023 via email

@fno2010
Copy link
Member

fno2010 commented May 11, 2023 via email

fno2010 added a commit that referenced this issue May 15, 2023
Added security considerations for writable data nodes that are
considered vulnerable. (#33)

    - feed-interval
    - poll-interval

Signed-off-by: jensenzhang <jingxuan.n.zhang@gmail.com>
@QiufangMa
Copy link
Contributor

QiufangMa commented May 20, 2023

I think there are more nodes that should be considered sensitive, I am trying to use the following text to replace security consideration on OAM draft(-07) starts from paragraph 3, see if that makes sense to you guys, feel free to amend:

There are a number of data nodes defined in these two YANG modules that are writable/creatable/deletable (i.e., config true, which is the default). These data nodes may be considered sensitive or vulnerable in some network environments. Write operations (e.g., edit-config) to these data nodes without proper protection can have a negative effect on network operations. These are the subtrees and data nodes in "ietf-alto" YANG module and their sensitivity/vulnerability:

/alto:alto/alto:alto-client/alto:server-discovery: This subtree specifies a set of parameters for an ALTO client to discover ALTO server. Unauthorized access to it could cause intruders to modify the ALTO discovery parameters(e.g., dns-server) so as to expose an ALTO client to fake ALTO servers.

/alto:alto/alto:alto-server/logging-system: This subtree provides configuration to select a logging system to capture log messages generated by an ALTO server. Unauthorized read access of this node can allow intruders to access logging information, which could be used to craft an attack the server.

/alto:alto/alto:alto-server/auth-client: This list specifies all the authenticated ALTO clients on an ALTO server. Unauthorized write access to this list can allow intruders to modify the entries so as to add a client that have not been authenticated yet or delete a client that has already been authenticated.

/alto:alto/alto:alto-server/role: This list specifies roles which authenticated ALTO clients assigned to for access control. Unauthorized write access to this list can allow intruders to modify the entries so as to permit access that should not be permitted, or deny access that should be permitted.

/alto:alto/alto:alto-server/data-source/feed-interval: This leaf specifies a period for an ALTO server to wait for updates published by the data source. A malicious client could attempt to set a very low/large value to this node. Setting a very low value could attack the data source. And setting a very large value would lead to maintaining stale data in the ALTO server.

/alto:alto/alto:alto-server/data-source/poll-interval:This leaf specifies a period for an ALTO server to proactively poll updates from a data source. A malicious client could attempt to set a very low/
large value to this node. Setting a very low value could attack
the data source. And setting a very large value would lead to
maintaining stale data in the ALTO server.

Please be aware that this module uses grouping from the "ietf-tls-server" module defined in
[I-D.ietf-netconf-tls-client-server]. All of the data nodes defined
in the grouping have the NACM extension "default-deny-write" set,
thus preventing unrestricted write-access to the data nodes defined
in those groupings.

@boucadair
Copy link
Contributor Author

I think there are more nodes that should be considered sensitive, I am trying to use the following text to replace security consideration on OAM draft(-07) starts from paragraph 3, see if that makes sense to you guys, feel free to amend:

Can you please propose this as a new PR so that we can review it easily? Thanks.

@QiufangMa
Copy link
Contributor

see #68

@boucadair
Copy link
Contributor Author

boucadair commented May 22, 2023

Thanks, Qiufang. I submitted my review to #68 right now.

@boucadair boucadair linked a pull request May 23, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WGLC comment received during WGLC
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants