Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factoring dataqualities in an sdfChoice #27

Closed
cabo opened this issue Mar 16, 2021 · 1 comment · Fixed by #69
Closed

Factoring dataqualities in an sdfChoice #27

cabo opened this issue Mar 16, 2021 · 1 comment · Fixed by #69
Assignees
@cabo
Labels
has PR

Comments

@cabo
Copy link
Member

cabo commented Mar 16, 2021

The second example in Section 4.7.2 seems to assume that dataqualities that are common to all choice branches can be factored out of the sdfChoice. This is currently not fully supported by the grammar.

Need to either fix the example or fix the grammar.

(Issue raised by Jana Kiesewalter.)
@cabo
Copy link
Member Author

cabo commented Feb 28, 2022

MJK: factoring makes for less noise

@cabo cabo self-assigned this Feb 28, 2022
cabo added a commit that referenced this issue Mar 17, 2022
@cabo
Allow factoring of dataqualities in sdfChoice
97d119c 
Close #27
@cabo cabo mentioned this issue Mar 17, 2022
Merged
@cabo cabo added the has PR label Mar 17, 2022
@cabo cabo closed this as completed in #69 Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cabo cabo

Labels
has PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

I27 choice factoring ietf-wg-asdf/SDF
1 participant
@cabo