fix sdfData multiplicities in UML diagram #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akeranen
approved these changes
Apr 11, 2022
|
Hmm, as a side note and a more general discussion point: The relationships between the classes are not rendered really well in the final text representation (the multiplicities, for example, are not rendered at all). Do you think it is beneficial to have the class diagram in the final draft nonetheless? Or could there be a different visual representation of the class structure which includes more information? Leaving the diagram as is would be fine, I suppose, but it also does not add that much additional value at the moment. (This comment could be converted into an issue once the PR is merged if these questions are worth discussing.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a closer look on the UML diagram in the document, I noticed that the multiplicities of
sdfInputDatainsdfActionandsdfOutputDatainsdfEventare currently set to 1+, while both fields are defined as optional in the CDDL schema.This PR therefore changes the multiplicity of both definitions to 0+, asuming that this is the correct value here. Otherwise the schema might need to be adjusted.