Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the bogus TagDefault value in the RFC #508

Closed
robUx4 opened this issue May 9, 2021 · 3 comments · Fixed by #510
Closed

Add the bogus TagDefault value in the RFC #508

robUx4 opened this issue May 9, 2021 · 3 comments · Fixed by #510
Labels
format addition spec_main Main Matroska spec document target XML Schema EBML Schema validation
Projects
Matroska specifications

Comments

@robUx4
Copy link
Contributor

robUx4 commented May 9, 2021

TagDefault has an EBML ID 0x4484, but some files exist with a value of 0x44B4, referred as MATROSKA_ID_TAGDEFAULT_BUG in libavcodec.

We should probably mention this value in the specs. Probably in the section of deprecated elements that is introduced by #487.
@robUx4 robUx4 added format addition spec_main Main Matroska spec document target XML Schema EBML Schema validation labels May 9, 2021
robUx4 added a commit that referenced this issue May 9, 2021
@robUx4
Add the 0x44B4 bogus TagDefault ID in the XSD
31ce1cb 
Since we're supposed to describe existing files, this value is found in the while.
It's parsed by libavformat as well.

The element is marked as deprecated since version 0, so should not be used.

Fixes #508
@robUx4 robUx4 mentioned this issue May 9, 2021
Merged
@hubblec4
Copy link
Contributor

hubblec4 commented May 9, 2021 •
edited

Means that a parser have to check/used both IDs for this element?

@robUx4
Copy link
Contributor Author

robUx4 commented May 10, 2021 •
edited

As investigated by Paul Foley, the bogus value was introduced in libmatroska 0.7.3 and fixed/replaced in libmatroska 0.9.0.
The history of commits in the library doesn't go that far on GitHub.

The fix appears in mkvtoolnix 2.9.9 released on 2009-11-25 with this commit https://gitlab.com/mbunkus/mkvtoolnix/-/commit/3c4aaf656222cdfdc0f77baf52607df0029cfc80

@robUx4
Copy link
Contributor Author

robUx4 commented May 10, 2021

Means that a parser have to check/used both IDs for this element?

Not mandatory. libmatroska doesn't do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
format addition spec_main Main Matroska spec document target XML Schema EBML Schema validation
Projects
Matroska specifications
Awaiting triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add the 0x44B4 bogus TagDefault ID in the XSD ietf-wg-cellar/matroska-specification
2 participants
@robUx4 @hubblec4