More deprecated elements #39
Conversation
|
In the "original" specs all those elements are marked as belonging to no version so I think it's fair to put maxver to 0 for all of them. |
This commit brings this specification in line with the old one on www.matroska.org. The elements shown as dark gray text on light gray background where all meant to be deprecated. Unfortunately the XML file in the matroska-foundation repository did not reflect this fact. As I couldn't find out when exactly each of those elements had been deprecated I chose to use version 3 as the maximum version.
|
Hmm good point. I've changed the commit to use |
|
Perhaps we need to explain somewhere that in the context of Matroska there is no version zero, but that version=0 is an alias for invalid or experimental. |
|
Reading this late, but am a bit concerned before this patch these elements were valid in many versions of Matroska but after the patch many files in the world are suddenly invalid. |
|
Can you quantify that? How many files do you have that contain one of those elements? Or is that more of a gut feeling? |
|
Actually the DivX elements exist in the wild. But that's a different question, should be keep track of what exists in other specs ? Like WebM and DivX. IMO we should make it easy for them to define what they support (like extra elements they can add to the XML) but it should not more. |
This pull request adds
minverandmaxverattributes to those elements that are currently shown gray-on-gray on the old specs page. The intention of those was to have them deprecated as well, but we never added the version attributes to the corresponding XML file.As I couldn't figure out when we decided not to use those elements after all I decoded to use 3 as the maximum version.
See also this comment by @robUx4.