Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move control track related content in a separate document #461

Merged
merged 8 commits into from Apr 11, 2021

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Mar 7, 2021

The new document is in a dirty state and we may never use it. But it's a way to clean the Control Track reference (an under specified and unused feature) out of the main document.

Fixes #456

@robUx4 robUx4 added formatting spec_main Main Matroska spec document target labels Mar 7, 2021
@hubblec4
Copy link
Contributor

hubblec4 commented Mar 7, 2021

move ChapterTrack and ChapterTrackUID in the Control Tracks spec

Is this really only for Control Tracks?

A good player could read the ChapterTrack and uses only the listed tracks (ordered chapters are required).

@robUx4
Copy link
Contributor Author

robUx4 commented Mar 14, 2021

ChapterTrack is useless without a ChapterTrackUID, because it means "all tracks", just as if it doesn't exist.

It's true that the ChapterTrackUID spec currently says

In the absence of a control track, choosing this chapter will select the listed Tracks and deselect unlisted tracks.

But just like control track it's not currently used so I'd rather move it out for now than delaying the specifications for something noone has ever used. Neither vlc nor libavformat support these elements.

@robUx4
Copy link
Contributor Author

robUx4 commented Mar 14, 2021

BTW, the specs contained as many features as we could think of, even not correctly/properly defined because the idea was to have as much "prior art" as possible. So if anyone tries to patent a new feature they can't because we already thought of it. Even the chapter codecs fall in this category except it got to a proof of concept in VLC.

We don't need these extra parts in the v1 to v4 specs which is meant to specify what is currently used in Matroska.

@robUx4 robUx4 requested review from mbunkus, dericed and mcr March 14, 2021 08:08
@robUx4 robUx4 force-pushed the control-track branch 2 times, most recently from ef1bd68 to 4c28140 Compare March 14, 2021 08:20
@robUx4 robUx4 mentioned this pull request Mar 14, 2021
chapters.md Outdated Show resolved Hide resolved
chapters.md Outdated Show resolved Hide resolved
chapters.md Outdated Show resolved Hide resolved
chapters.md Outdated Show resolved Hide resolved
index_control.md Outdated Show resolved Hide resolved
index_control.md Outdated Show resolved Hide resolved
chapters.md Outdated Show resolved Hide resolved
@robUx4
Copy link
Contributor Author

robUx4 commented Mar 28, 2021

Rebased after the #342 merge which had more text based on now-moved elements. As a result some tables and text have been simplified.

This is an advanced feature currently not used that will work better with
Control Tracks and more advanced tracks selection than the one currently defined
in the Matroska Specifications.
Since it's not used and only usable by control tracks, we can move it there.
There is no other way to toggle it and it should not be mentioned in the
main spec which doesn't deal with control tracks.
There is no other way to toggle the flag and it's not defined anywhere else.

it's unlikely to be used anywhere, unlike ChapterFlagHidden which can be used
to have chapter codecs invisible to the user.
It was meant to use Control Tracks and is irrelevant in the main specs.
@robUx4
Copy link
Contributor Author

robUx4 commented Mar 28, 2021

Rebase after #469 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
formatting spec_main Main Matroska spec document target
Projects
Development

Successfully merging this pull request may close these issues.

Remove mentions of Control Track in the main spec
3 participants