Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow chapter duration of 0 #552

Merged
merged 4 commits into from Jan 2, 2022
Merged

allow chapter duration of 0 #552

merged 4 commits into from Jan 2, 2022

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Aug 27, 2021

There can be segments with just chapters containing commands.

In ordered chapters the content will not play anything, it may seek to the
position for nothing but that's not a big deal.

Fixes #542

@robUx4 robUx4 added bug clarifications spec_main Main Matroska spec document target labels Aug 27, 2021
@robUx4
Copy link
Contributor Author

robUx4 commented Nov 28, 2021

When exporting a DVD to Matroska the "first play PGC" often just contains a command. In Matroska chapter that corresponds to an empty chapter with an enter (or leave) command.

Here's an example output of DvdMenuXtractor:

		<!-- First Play PGC -->
		<ChapterAtom>
			<ChapterUID>1729839304</ChapterUID>
			<ChapterTimeStart>00:00:00.000000000</ChapterTimeStart>
			<ChapterTimeEnd>00:00:00.000000000</ChapterTimeEnd>

	<!-- Enter your text here -->
	<ChapterDisplay>
			<ChapterString>First Play PGC 1729839304</ChapterString>
	</ChapterDisplay>

			<ChapterProcess>
				<ChapterProcessCodecID>1</ChapterProcessCodecID>
				<ChapterProcessPrivate format="hex">30 00 00 00 </ChapterProcessPrivate>
				<!-- Pre commands -->
				<ChapterProcessCommand>
					<ChapterProcessTime>1</ChapterProcessTime>
					<ChapterProcessData format="hex">02 53 00 00 00 00 0f 00 00 30 06 00 00 00 42 00 00 </ChapterProcessData>
				</ChapterProcessCommand>
			</ChapterProcess>
		</ChapterAtom>

So it is needed in ordered chapters. It doesn't make a lot of sense in unordered chapters, but could be used as a marker of position (for example in an audio or video editor).

We do say that the end value is timestamp excluded. So we may clarify what to do with this when the start is equal to the end as it means the same timestamp is both included and excluded.

There can be segments with just chapters containing commands.

In ordered chapters the content will not play anything, it may seek to the
position for nothing but that's not a big deal.

Fixes #542
@robUx4
Copy link
Contributor Author

robUx4 commented Jan 2, 2022

Fixed some typo for greater than or equal to .

@robUx4 robUx4 merged commit c70e7f4 into master Jan 2, 2022
@robUx4 robUx4 deleted the chapter-null-duration branch January 2, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug clarifications spec_main Main Matroska spec document target
Projects
Development

Successfully merging this pull request may close these issues.

really allow 0 duration chapters
1 participant