Add a normative section about Tag level emptying #770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robUx4
added
clarifications
spec_main
retokromer
reviewed
May 29, 2023
mbunkus
requested changes
May 29, 2023
tags-precedence.md
Outdated
| doesn't apply to a level but the actual value to use is not known, | ||
| an empty `TagString` ((#tagstring-element)) or an empty `TagBinary` ((#tagbinary-element)) element **MUST** be used as the tag value for this level. | ||
|
|
||
| See [@?MatroskaTags] for more details on common tags values. |
There was a problem hiding this comment.
Isn't "common tags values" wrong here? If you think about the Matroska tagging system as a listed of key/value pairs, the "value of a tag" is e.g. "Mozart", not "COMPOSER". I guess you're trying to refer to the common values of the TagString element here, but that's not what a lay person would understand to be the "value of a tag".
There was a problem hiding this comment.
I reword it to be a little more precise on what to expect there.
This is the same normative information currently found in the Tags document.
In the end there's no paragraph to talk about this informational string.
mbunkus
approved these changes
May 29, 2023
retokromer
approved these changes
May 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a rewritten section of a rule that exists in the Tags document.
Plus some cleaning.