Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drop "Redirect to a Shortened URL" #139

Merged
merged 5 commits into from Dec 23, 2020
Merged

drop "Redirect to a Shortened URL" #139

merged 5 commits into from Dec 23, 2020

Conversation

aaronpk
Copy link
Collaborator

@aaronpk aaronpk commented Dec 3, 2020 •
edited

closes #121 and closes #53

jricher
jricher requested changes Dec 4, 2020
View reviewed changes
Copy link
Collaborator

@jricher jricher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same change needs to be made in the appendix under "Secondary Device Interaction {#example-device}".

One of these examples can keep the redirection as an option alongside the user code, just not the shortened form.

draft-ietf-gnap-core-protocol.md Outdated Show resolved Hide resolved
draft-ietf-gnap-core-protocol.md Show resolved Hide resolved
aaronpk and others added 2 commits December 4, 2020 07:09
@aaronpk @jricher
Update draft-ietf-gnap-core-protocol.md
8e53f76 
Co-authored-by: Justin Richer <github@justin.richer.org>
@aaronpk @jricher
Update draft-ietf-gnap-core-protocol.md
f7833d8 
Co-authored-by: Justin Richer <github@justin.richer.org>
@aaronpk
Copy link
Collaborator Author

aaronpk commented Dec 4, 2020

Thanks, I missed that!

@aaronpk aaronpk requested a review from jricher December 4, 2020 15:09
@aaronpk aaronpk marked this pull request as draft December 16, 2020 16:43
@aaronpk aaronpk self-assigned this Dec 16, 2020
@aaronpk aaronpk marked this pull request as ready for review December 16, 2020 19:18
@jricher jricher added the Pending Merge PR will be merged unless there are changes to consensus label Dec 16, 2020
@jricher jricher merged commit 0e530f3 into ietf-wg-gnap:main Dec 23, 2020
@jricher jricher removed the Pending Merge PR will be merged unless there are changes to consensus label Dec 23, 2020
@aaronpk aaronpk deleted the issue-121-shorturl branch January 27, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jricher jricher jricher approved these changes

Assignees

@aaronpk aaronpk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redirect to an Arbitrary Shortened URL Error mode for short interaction URL
2 participants
@aaronpk @jricher