added starter JSON schemas in appendix #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaronf
reviewed
Oct 28, 2020
| "type": "array", | ||
| "items": { | ||
| "type": "string", | ||
| "pattern": "^[a-z]{2,}-[A-Z]{2,}$"/* will need a better pattern for language tags*/ |
There was a problem hiding this comment.
No, I think we'll have to punt this one to the application.
| } | ||
| } | ||
| }, | ||
| "subject_id_types": { |
There was a problem hiding this comment.
This would benefit from a common "include file".
| }, | ||
| "updated_at": { | ||
| "type": "string", | ||
| "pattern": "([0-9]{4})-([0-9]{2})-([0-9]{2})T([0-9]{2})\\:([0-9]{2})\\:([0-9]{2})" |
There was a problem hiding this comment.
Not sure this pattern is needed, you should have an ISO8601 parser anyway.
There was a problem hiding this comment.
It's as much value as defining a string field as a uri type, since an application would have a URI parser also.
There was a problem hiding this comment.
Yes, but here you're using the schema definition to define a time format, maybe even a new time format.
Closed
|
The schema has changed significantly since this was submitted, closing now and tracking the need for this in #166 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a proposed JSON Schema to the appendix as a resource for developers. This schema currently covers the main request and response messages.