New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update error response as an object or as a string #452
Conversation
✅ Deploy Preview for gnap-core-protocol-editors-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This doesn't build, will look at that tomorrow |
@fimbault : the build errors are due to the IANA section anchors being changed: you have a reference to the (old) |
thanks @jricher for the hint, i'll fix that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There were a number of places where the error is displayed to the user instead of returned from the AS in a message, so in those places error codes aren't needed/used. I've backed those out and will merge them. Those error codes can probably be marked as being returned from the AS in the post interaction stage though, so we might want to put more text there.
Closes #79
This issue also checks all errors :