Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update error response as an object or as a string #452

Merged
merged 13 commits into from Oct 24, 2022

Conversation

fimbault
Copy link
Collaborator

@fimbault fimbault commented Oct 13, 2022

Closes #79

This issue also checks all errors :

  • in section 1 : when referring to errors, it is a generic term / no change needed
  • same in the security considerations
  • elsewhere we aim to have specific errors

@netlify
Copy link

netlify bot commented Oct 13, 2022

Deploy Preview for gnap-core-protocol-editors-draft ready!

Name Link
🔨 Latest commit 4dff4ed
🔍 Latest deploy log https://app.netlify.com/sites/gnap-core-protocol-editors-draft/deploys/635696366992370008c806cf
😎 Deploy Preview https://deploy-preview-452--gnap-core-protocol-editors-draft.netlify.app/draft-ietf-gnap-core-protocol
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@fimbault
Copy link
Collaborator Author

This doesn't build, will look at that tomorrow

@jricher
Copy link
Collaborator

jricher commented Oct 14, 2022

@fimbault : the build errors are due to the IANA section anchors being changed: you have a reference to the (old) IANA-error-response-template which should now be IANA-error-code-template, and you need to update the anchor for IANA-error-response-contents to IANA-error-code-contents. I only see those two but do a text search on those anchors.

@fimbault
Copy link
Collaborator Author

thanks @jricher for the hint, i'll fix that

@fimbault fimbault changed the title update error response as an object update error response as an object or as a string Oct 22, 2022
@fimbault fimbault requested a review from jricher October 22, 2022 16:22
Copy link
Collaborator

@jricher jricher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a number of places where the error is displayed to the user instead of returned from the AS in a message, so in those places error codes aren't needed/used. I've backed those out and will merge them. Those error codes can probably be marked as being returned from the AS in the post interaction stage though, so we might want to put more text there.

draft-ietf-gnap-core-protocol.md Outdated Show resolved Hide resolved
draft-ietf-gnap-core-protocol.md Outdated Show resolved Hide resolved
draft-ietf-gnap-core-protocol.md Show resolved Hide resolved
draft-ietf-gnap-core-protocol.md Outdated Show resolved Hide resolved
draft-ietf-gnap-core-protocol.md Outdated Show resolved Hide resolved
draft-ietf-gnap-core-protocol.md Outdated Show resolved Hide resolved
draft-ietf-gnap-core-protocol.md Outdated Show resolved Hide resolved
draft-ietf-gnap-core-protocol.md Outdated Show resolved Hide resolved
draft-ietf-gnap-core-protocol.md Outdated Show resolved Hide resolved
draft-ietf-gnap-core-protocol.md Outdated Show resolved Hide resolved
@jricher jricher merged commit ee9e7b8 into ietf-wg-gnap:main Oct 24, 2022
@jricher jricher deleted the 79 branch October 24, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error responses
2 participants