Discuss source of account identifiers from client's perspective #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gnap-core-protocol-editors-draft ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
fimbault
reviewed
Nov 15, 2022
draft-ietf-gnap-core-protocol.md
Outdated
| @@ -2308,6 +2333,13 @@ the client instance MUST use an identity protocol to request and receive additio | |||
| claims. The details of an identity protocol and associated schema | |||
| are outside the scope of this specification. | |||
|
|
|||
| The client instance MUST interpret all subject information in the context of the AS that the | |||
| subject information is received from, as is discussed in {{SP80063C}}. For example, one AS could | |||
There was a problem hiding this comment.
Is this reference necessary ?
I think we could mostly take the general idea, that those subject identifiers are asserted by the system at some point and no global (except maybe for public DIDs).
In practice this means: don't do a basic string comparison
fimbault
requested changes
Nov 15, 2022
jricher
force-pushed
the
subject-source
branch
from
62d8460
to
69c2f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #461