Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken Link header fields #26

Closed
reschke opened this issue Jun 22, 2021 · 8 comments
Closed

broken Link header fields #26

reschke opened this issue Jun 22, 2021 · 8 comments
Assignees

Comments

@reschke
Copy link
Contributor

reschke commented Jun 22, 2021

There are examples of the type:

Link: <https://example.org/links/resource1> ; rel="alternate" 
; type="application/linkset+json"

Note that whitespace would be needed in the continuation line.

@hvdsomp
Copy link
Collaborator

hvdsomp commented Jun 22, 2021 via email

@reschke
Copy link
Contributor Author

reschke commented Jun 22, 2021

Yes, I know that.

But what you currently use is not an HTTP message. You can fix it by adding leading whitespace.

@dret
Copy link
Collaborator

dret commented Jun 23, 2021

sounds like an easy fix. i'll have a look and if we change the example(s) it seems we can also remove the cautionary note in the terminology section?

@dret dret self-assigned this Jun 23, 2021
@hvdsomp
Copy link
Collaborator

hvdsomp commented Jun 23, 2021

Personally, I would prefer handling all examples in the way it's done in Figure 12 (see below) and keep the cautionary note. I think that approach really helps for legibility.

HTTP/1.1 200 OK
Date: Mon, 12 Aug 2019 10:45:54 GMT
Server: Apache-Coyote/1.1
Link: <https://example.org/links/resource1>
         ; rel="linkset"
         ; type="application/linkset+json"
Content-Length: 236
Content-Type: text/html;charset=utf-8

@dret
Copy link
Collaborator

dret commented Jun 23, 2021

my guess is @reschke refers to this example:

Link: <https://example.org/links/resource1> ; rel="alternate" 
; type="application/linkset+json"

(and a second one like it) which indeed seem to be in need of fixing.

dret added a commit that referenced this issue Jun 23, 2021
@dret
Copy link
Collaborator

dret commented Jun 23, 2021 via email

@reschke
Copy link
Contributor Author

reschke commented Jun 23, 2021

Yes, this issue is addressed.

Note that

line breaks are not allowed in values for HTTP headers

is a bit misleading; "deprecated" would be more precise.

dret added a commit that referenced this issue Jun 23, 2021
@dret
Copy link
Collaborator

dret commented Jun 25, 2021

assuming that we have no fully addressed this issue, i am closing it. thanks, @reschke!

@dret dret closed this as completed Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants